Closes #11: handle translations #12
Conversation
|
As a follow-up we'll need to update the composer.json file for WP Rocket & Imagify to be compatible with these changes. |
There was a problem hiding this comment.
It works with me perfectly with both composer install and composer update.
I really was trying to include post-install-cmd and post-update-cmd inside the plugin family composer.json but for a security reason it didn't work and it needs to be inside the rocket composer file for example, I tried this to make the process easier because this will be integrated in multiple plugins.
The only remaining thing here is to document that in notion, can u plz create a document mentioning the steps to require this plugin family package in any plugin?
|
@wp-media/engineering-plugin-team This one can be Test by dev: adding screenshot of the plugins view on WPR / imagify for FR translation (please check with product what other translation is there to be checked) |
Description
This PR adds a post install composer script to apply appropriate text domain during package install/update.
Fixes #11
Fixes translation issue with this package on plugins.
Type of change
Detailed scenario
Currently present on the latest stable.
Technical description
Documentation
Created a script to update the model data with the correct text domain gotten from the plugin composer config during package installation/update.
New dependencies
N/A
Risks
N/A
Mandatory Checklist
Code validation
Code style
Unticked items justification
If some mandatory items are not relevant, explain why in this section.
Additional Checks